feat: Integrate SubscriptionController into wallet initialization#9598
Open
tuna1207 wants to merge 7 commits into
Open
feat: Integrate SubscriptionController into wallet initialization#9598tuna1207 wants to merge 7 commits into
tuna1207 wants to merge 7 commits into
Conversation
pedronfigueiredo
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adds SubscriptionController as a default initialized unit in @metamask/wallet, with injectable or default SubscriptionService construction and AuthenticationController messenger delegation.
@metamask/wallet is the shared controller-integration layer for extension, mobile, and other clients. Build-specific and runtime values are injected via instanceOptions rather than hardcoded.
Breaking changes
References
Checklist
Note
High Risk
Breaking change for all
@metamask/walletconsumers (new requiredinstanceOptions) and subscription flows depend on correctAuthenticationControllerregistration for authenticated API calls.Overview
BREAKING:
@metamask/walletnow initializesSubscriptionControllerby default and requires a newinstanceOptions.subscriptionControllerslot (env,fetchFunction, plus optional service/token/polling overrides). The package adds@metamask/subscription-controller, wires messenger delegation toAuthenticationControllerfor bearer tokens, and re-exportsSubscriptionEnvfrom the wallet entrypoint.Wallet-cli’s daemon factory passes production env and
globalThis.fetchfor that slot (noAuthenticationControlleron the CLI root messenger, so authenticated subscription calls still need host wiring). Tests, changelogs, CODEOWNERS, and README dependency graph are updated accordingly.Reviewed by Cursor Bugbot for commit 01320db. Bugbot is set up for automated code reviews on this repo. Configure here.